feat(garm): add get-credentials action#254
Open
Thanhphan1147 wants to merge 14 commits into
Open
Conversation
Thanhphan1147
requested review from
cbartz,
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
cbartz
approved these changes
Jun 25, 2026
cbartz
left a comment
cbartz
left a comment
Collaborator
There was a problem hiding this comment.
LGMT. This was not planned, but seems indeed like a useful feature.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a get-credentials Juju action to the garm charm to expose the admin credentials stored in the garm-admin-credentials Juju secret, along with unit/integration test coverage and a new how-to guide documenting usage.
Changes:
- Add
get-credentialsaction wiring in the charm and declare it incharmcraft.yaml. - Add unit + integration tests for the action’s success/failure behavior.
- Add a new how-to guide and link it from the docs how-to index; update
.gitignoreentries.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
charms/garm/src/charm.py |
Observes and implements the get-credentials action handler that returns admin secret content. |
charms/garm/charmcraft.yaml |
Declares the get-credentials action. |
charms/garm/tests/unit/test_charm.py |
Adds unit tests covering action success and failure paths. |
charms/tests/integration/test_garm.py |
Adds an integration test that runs the action and validates returned fields. |
docs/how-to/retrieve-garm-credentials.md |
Adds a how-to guide describing how to run the action and interpret output. |
docs/how-to/index.rst |
Adds the new how-to page to the toctree. |
.gitignore |
Fixes .vscode/ ignore entry and adds .worktrees/. |
Thanhphan1147
commented
Jun 26, 2026
auto-merge was automatically disabled
June 26, 2026 13:23
Head branch was pushed to by a user without write access
Thanhphan1147
commented
Jun 26, 2026
…n charmcraft.yaml
erinecon
approved these changes
Jun 26, 2026
Co-authored-by: Erin Conley <erin.conley@canonical.com>
yhaliaw
approved these changes
Jun 30, 2026
Co-authored-by: Erin Conley <erin.conley@canonical.com>
yhaliaw
reviewed
Jul 3, 2026
yhaliaw
left a comment
yhaliaw
left a comment
Collaborator
There was a problem hiding this comment.
Posting three minor findings from a code review pass — all cosmetic/convention issues, none blocking.
Co-authored-by: Andrew Liaw <andrew.liaw@canonical.com>
Co-authored-by: Andrew Liaw <andrew.liaw@canonical.com>
Author
|
Hi @yhaliaw, I resolved the conflicts but there seems to be some formatting done on the test files, can you check to see if they are normal? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-credentialsJuju action to the GARM charm, exposing the admin credentials stored in thegarm-admin-credentialsJuju secret to the operatorUsage